[PATCH] D77773: PowerPC: Don't lower SELECT_CC to PPCISD::FSEL on SPE
Kai Luo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 27 23:09:20 PDT 2020
lkail accepted this revision.
lkail added a comment.
This revision is now accepted and ready to land.
LGTM. Please hold on a couple of days in case others have comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7770
+ !Op.getOperand(2).getValueType().isFloatingPoint() ||
+ Subtarget.hasSPE())
return Op;
----------------
nit: Move this line to the above(`clang-format` might comment in a wrong line :o).
================
Comment at: llvm/test/CodeGen/PowerPC/spe-fastmath.ll:3
+; RUN: llc -verify-machineinstrs < %s -mtriple=powerpc-unknown-linux-gnu \
+; RUN: -mattr=+spe | FileCheck %s
+
----------------
nit: 2-space indentation against last line should be enough.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77773/new/
https://reviews.llvm.org/D77773
More information about the llvm-commits
mailing list