[PATCH] D78835: [flang] Upstream recent work on FIR to llvm-project.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 27 18:53:02 PDT 2020


mehdi_amini added a comment.

In D78835#2005053 <https://reviews.llvm.org/D78835#2005053>, @DavidTruby wrote:

> Would it be possible to update the commit message/summary to describe what's changed here?


I think it'd be great to keep the commit messages in the repo actually being descriptive: "Upstream recent work on FIR to llvm-project" does not tell us anything about the commit, compared to for example something like "Add MemoryEffects to FIR operations".

It also seems like this is mixing a bunch of different thing that really should be different commits instead (That may contributes to the difficulty to provide a clear commit message).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78835/new/

https://reviews.llvm.org/D78835





More information about the llvm-commits mailing list