[PATCH] D78863: [MLIR] Introduce op trait PolyhedralScope

[Andy Davis via Phabricator via llvm-commits]

andydavis1 accepted this revision.
andydavis1 added a comment.

Thanks Uday...



================
Comment at: mlir/lib/Dialect/Affine/IR/AffineOps.cpp:140
+
+// Value can be used as a dimension id if it is valid as a symbol, or it is an
+// induction variable, or it is a result of an affine apply operation with
----------------
Same comment as for isSymbol. Make the conditions a list, so its easier for people to see the set of conditions.


================
Comment at: mlir/lib/Dialect/Affine/IR/AffineOps.cpp:225
+
+// Value can be used as a symbol for `region` if it is a constant, or is defined
+// at the top level of 'region' or is its argument, or dominates `region`'s
----------------
There are a lot of "ors" in this description, and this is the place most people will be looking for what the definition of what a symbol is.  Could you make this a bullet list:
// Value can be used as a symbol iff it meets one of the following conditions:
// *) It is a constant.
// *) It is defined at the top level of 'region'...
// *) ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78863/new/

https://reviews.llvm.org/D78863