[PATCH] D78309: [LLVM] Remove wrong DBG_VALUE instruction with one operand in AArch64 test case

Mon Apr 27 16:11:54 PDT 2020

dsanders added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/branch-target-enforcement.mir:343
     ; CHECK-NOT: HINT
-    ; CHECK: DBG_VALUE
     ; CHECK: frame-setup PACIASP
----------------
danielkiss wrote:
> efriedma wrote:
> > I think this is breaking the point of the test: it's specifically supposed to be checking that DBG_VALUE instructions don't confuse the transform.  (So the test doesn't really care what the DBG_VALUE is, but it does care that one exists.)
> > 
> > Probably not too important, but still.
> For background please take a look: D74492
> I prefer to fix the DBG_VALUE instead of removing.
I don't mind if it comes back as a valid instruction but there's currently no DILocalVariable to attach to it (or other LLVM-IR level debug info) and the LLVM-IR function doesn't have any values we could turn into one.

The code in D74492 is using isMetaInstruction() rather than isDebugInstruction() so maybe there's another instruction that would serve the purpose without needing to add all the LLVM-IR level debug info

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78309/new/

https://reviews.llvm.org/D78309