[PATCH] D78888: [llvm-objcopy][MachO] Fix symbol table

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 27 15:39:44 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/symbol-table.test:427
+    - ''
+    - dyld_stub_binder
+    - __mh_execute_header
----------------
I think we probably need a way to let yaml2obj construct the string table. We write something like `String: ...` and let yaml2obj fill in the n_strx field.

This can be cleaned up later, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78888/new/

https://reviews.llvm.org/D78888





More information about the llvm-commits mailing list