[PATCH] D78966: Don't crash on duplicate keys in dictionary attrs.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 27 15:39:43 PDT 2020


rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Parser/Parser.cpp:1679
 
+  llvm::SmallDenseSet<Identifier> uniquifier;
   auto parseElt = [&]() -> ParseResult {
----------------
nit: uniquifier sounds weird, can we just do something like "usedNames"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78966/new/

https://reviews.llvm.org/D78966





More information about the llvm-commits mailing list