[PATCH] D78946: [llvm-objcopy][MachO] Handle relocations where r_extern is 0

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

LGTM from the Mach-O side.



================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOReader.cpp:222
+          } else {
+            assert(SymbolNum >= 1 && SymbolNum <= Sections.size() &&
+                   "Invalid section index.");
----------------
Should this be a user-visible error instead? It can happen for a malformed input file, for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78946/new/

https://reviews.llvm.org/D78946