[PATCH] D78898: [llvm-objcopy][MachO] Avoid accidental invalid relocations in tests
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 27 14:34:21 PDT 2020
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/test/tools/llvm-objcopy/MachO/Inputs/strip-all-with-dwarf.yaml:46
+ - address: 0x0
+ symbolnum: 0
+ pcrel: false
----------------
I don't think it makes much difference for this test, but would it be better/more realistic to have some of these pointing to different symbols?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78898/new/
https://reviews.llvm.org/D78898
More information about the llvm-commits
mailing list