[PATCH] D74651: Add IR constructs for inalloca replacement preallocated call setup

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 27 14:34:18 PDT 2020


efriedma added a comment.

> I've changed the LangRef to say that. I'm not sure if I'm overspecifying in the LangRef though, maybe that should be an implementation detail?

LangRef can't require that lowering be implemented some specific way; that would break the as-if rule.  The important bit is that it can be implemented that way, and that might be the simplest way to explain the point.

But maybe we don't actually need to include that sentence in LangRef at all; the fact that it's legal to lower that way should be implied from the other rules.  And if it isn't implied, it's probably better to clarify the other rules.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74651/new/

https://reviews.llvm.org/D74651





More information about the llvm-commits mailing list