[PATCH] D78831: [SVE] Upgrade VectorType tests to test new types

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/unittests/IR/VectorTypesTest.cpp:31
+                      << #LHS << " = " << printVTy(LHS) << " and " << #RHS     \
+                      << " = " << printVTy(RHS);
+
----------------
I think you can just write `*RHS` (operator<< is overloaded for `const Type &T`)


================
Comment at: llvm/unittests/IR/VectorTypesTest.cpp:160
+  EXPECT_VTY_NE(ScV8Int32Ty, ScV8Int8Ty);
+  EXPECT_EQ(ScV8Int8Ty->getMinNumElements(), ScV8Int32Ty->getMinNumElements());
+  EXPECT_EQ(ScV8Int8Ty->getElementType()->getScalarSizeInBits(), 8U);
----------------
Do you not want to test for getElementCount here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78831/new/

https://reviews.llvm.org/D78831