[PATCH] D78954: [LLD][ELF] Add isDebug flag to SectionBase.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Most links don't use --strip-debug or --strip-all, so `isDebugSection` in `LinkerDriver::link` is rarely called.

Most links don't specify -r or --emit-relocs, so `InputSection::copyRelocations` is not called. In addition, `isDebugInfo` inside the function is called by edge cases which we have to suppress warnings for practical reasons, the cases are even fewer.

I am hesitant to accept this patch, unless you can make further justification.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78954/new/

https://reviews.llvm.org/D78954