[PATCH] D72223: [MLIR] Introduce affine.execute_region op

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/lib/Dialect/Affine/IR/AffineOps.cpp:2305
+        continue;
+    if (auto *defOp = memref.getDefiningOp())
+      // FIXME: this will only work if the memrefs collected above didn't
----------------
You don't need an `if` here.



================
Comment at: mlir/lib/Dialect/Affine/IR/AffineOps.cpp:2309
+      if (defOp->getParentOfType<AffineExecuteRegionOp>() == op)
+        continue;
+    return op.emitOpError("incoming memref not explicitly captured");
----------------
Seems like you can fix the FIXME and just write: `if(op->isProperAncestor(memref.getDefiningOp()) continue;`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72223/new/

https://reviews.llvm.org/D72223