[PATCH] D78849: [MachineVerifier] retrofit iterators with range for. NFC

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:178
+        return llvm::any_of(
+            RM, [this](const auto &P) { return addRequired(P.first); });
       }
----------------
nickdesaulniers wrote:
> nickdesaulniers wrote:
> > build failures look like:
> > 
> > ```
> > llvm/llvm/lib/CodeGen/MachineVerifier.cpp:178:70: error: cannot call member function ‘bool {anonymous}::MachineVerifier::BBInfo::addRequired(unsigned int)’ without object
> > 
> > error: void value not ignored as it ought to be
> > ```
> > 
> > Not sure why I don't see these locally?  Does the lambda need `this->addRequired`?
> `g++` specific bug?
> https://stackoverflow.com/questions/32097759/calling-this-member-function-from-generic-lambda-clang-vs-gcc
> Are these builders using `g++` to build clang? Logs say:
> `/usr/bin/c++`
I'm building clang with clang locally, so maybe that's it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78849/new/

https://reviews.llvm.org/D78849