[PATCH] D74729: [FPEnv] Intrinsic for setting rounding mode

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 27 12:22:55 PDT 2020


kpn added a comment.

I think we need to be clear in the documentation that this is _not_ a substitute for the constrained FP intrinsics. Can you please add that to your new documentation? Include a link to the "Floating-Point Environment" section in the language ref.

Add to the IR verifier checks that the input is a constant that matches the documentation. The type and input values all need to be checked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74729/new/

https://reviews.llvm.org/D74729





More information about the llvm-commits mailing list