[PATCH] D78864: [MLIR] Add getBody() method to SingleImplicitBlockTerminator op trait.
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 27 11:49:26 PDT 2020
rriddle accepted this revision.
rriddle added a comment.
This revision is now accepted and ready to land.
Looks great, thanks for the cleanup! LGTM after resolving the comments about assert messages
================
Comment at: mlir/include/mlir/IR/Builders.h:213
+ auto *terminator = block->getTerminator();
+ assert(terminator != nullptr && "The block has no terminator.");
+ return OpBuilder(block, terminator->getIterator());
----------------
nit: Please update all of the asserts to start with lowercase and end with no period.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78864/new/
https://reviews.llvm.org/D78864
More information about the llvm-commits
mailing list