[PATCH] D78934: [mlir][spirv] Fix SPIR-V translation registration

[Lei Zhang via Phabricator via llvm-commits]

antiagainst updated this revision to Diff 260368.
antiagainst added a comment.
Herald added a subscriber: bader.

Address comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78934/new/

https://reviews.llvm.org/D78934

Files:
  mlir/include/mlir/InitAllTranslations.h
  mlir/lib/Dialect/SPIRV/Serialization/TranslateRegistration.cpp


Index: mlir/lib/Dialect/SPIRV/Serialization/TranslateRegistration.cpp
===================================================================
--- mlir/lib/Dialect/SPIRV/Serialization/TranslateRegistration.cpp
+++ mlir/lib/Dialect/SPIRV/Serialization/TranslateRegistration.cpp
@@ -61,7 +61,7 @@
 }
 
 namespace mlir {
-void registerToSPIRVTranslation() {
+void registerFromSPIRVTranslation() {
   TranslateToMLIRRegistration fromBinary(
       "deserialize-spirv",
       [](llvm::SourceMgr &sourceMgr, MLIRContext *context) {
@@ -101,7 +101,7 @@
 }
 
 namespace mlir {
-void registerFromSPIRVTranslation() {
+void registerToSPIRVTranslation() {
   TranslateFromMLIRRegistration toBinary(
       "serialize-spirv", [](ModuleOp module, raw_ostream &output) {
         return serializeModule(module, output);
Index: mlir/include/mlir/InitAllTranslations.h
===================================================================
--- mlir/include/mlir/InitAllTranslations.h
+++ mlir/include/mlir/InitAllTranslations.h
@@ -17,6 +17,7 @@
 namespace mlir {
 
 void registerFromLLVMIRTranslation();
+void registerFromSPIRVTranslation();
 void registerToLLVMIRTranslation();
 void registerToSPIRVTranslation();
 void registerToNVVMIRTranslation();
@@ -29,6 +30,7 @@
 inline void registerAllTranslations() {
   static bool init_once = []() {
     registerFromLLVMIRTranslation();
+    registerFromSPIRVTranslation();
     registerToLLVMIRTranslation();
     registerToSPIRVTranslation();
     registerToNVVMIRTranslation();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78934.260368.patch
Type: text/x-patch
Size: 1505 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200427/08ef9513/attachment.bin>