[PATCH] D78922: [NFCI][CostModel] Remove getExtCost

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 27 09:06:42 PDT 2020


samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:730
           ((Opcode == Instruction::ZExt) ? ISD::ZEXTLOAD : ISD::SEXTLOAD);
         if (TLI->isLoadExtLegal(LType, ExtVT, LoadVT))
           return 0;
----------------
RKSimon wrote:
> This doesn't look as effective as the getTLI()->isExtLoad call in getExtCost - missing one use checks etc.
Thanks, I hadn't done that intentionally. I've uploaded that change in D78937 because it stops this patch from looking like an NFC. I'm not sure whether the vectorization changes are good/expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78922/new/

https://reviews.llvm.org/D78922





More information about the llvm-commits mailing list