[PATCH] D78736: [DWARF5]: Added support for dumping strx forms in llvm-dwarfdump

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX updated this revision to Diff 260342.
SouraVX added a comment.

Addressed @ikudrin comments, Thanks for this!

- Addressed the case when there are no records in map. By asserting it before we parsing the _strx form.
- Addressed test case related comments. Thanks for this, now test is more reduced and more readeable.
- lambda removal, using `DWARFUnit`, using `try_emplace`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78736/new/

https://reviews.llvm.org/D78736

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/test/DebugInfo/X86/debug-macro-multi-cu-strx.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78736.260342.patch
Type: text/x-patch
Size: 10671 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200427/9e9fcae9/attachment.bin>