[PATCH] D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug

[David Stenberg via Phabricator via llvm-commits]

dstenb added inline comments.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:805-806
+    for (; Suc != MBB->instr_end() && Suc->isBundledWithPred(); ++Suc) {
+      if (interpretValue(&(*Suc), ForwardedRegWorklist, EmptyExpr, Params,
+                         ShouldTryEmitEntryVals, NewWorklistItems))
+        return;
----------------
djtodoro wrote:
> dstenb wrote:
> > Might there be some target where a parameter value is produced by a series of delay slot instructions? If so, should this search start from the bottom of the delay slot bundle?
> I guess that we are operating with the targets with only one instruction within delay slot. I think we can get rid of the `for` loop, and add a `comment + assert()` describing that we expect only one instruction within the bundle.
> 
> @dstenb Does that sound OK to you?
That sounds good to me!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78107/new/

https://reviews.llvm.org/D78107