[PATCH] D78921: [llvm-objcopy] [COFF] Fix a misconception about debug directory payloads

Mon Apr 27 06:25:10 PDT 2020

mstorsjo created this revision.
mstorsjo added reviewers: rnk, ruiu, jhenderson, rupprecht.
Herald added subscribers: abrachet, MaskRay.
Herald added a reviewer: alexshap.
Herald added a project: LLVM.

The debug directory payload is not located directly after the debug directory entry itself, but can essentially be located anywhere in the binary (even outside of mapped sections, although we don't handle that case).

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78921

Files:
  llvm/test/tools/llvm-objcopy/COFF/debug-dir-unmapped.test
  llvm/test/tools/llvm-objcopy/COFF/patch-debug-dir2.test
  llvm/tools/llvm-objcopy/COFF/Writer.cpp
  llvm/tools/llvm-objcopy/COFF/Writer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78921.260295.patch
Type: text/x-patch
Size: 6645 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200427/9d2a3431/attachment.bin>