[llvm] 0f16d66 - [NFC][CostModel] Refactor getCastInstrCost

[Sam Parker via llvm-commits]

Author: Sam Parker
Date: 2020-04-27T12:42:34+01:00
New Revision: 0f16d66c80eb0b65c4ae55e27671d46f66be065f

URL: https://github.com/llvm/llvm-project/commit/0f16d66c80eb0b65c4ae55e27671d46f66be065f
DIFF: https://github.com/llvm/llvm-project/commit/0f16d66c80eb0b65c4ae55e27671d46f66be065f.diff

LOG: [NFC][CostModel] Refactor getCastInstrCost

Move ZExt/SExt load handling into the BasicTTI switch statement.

Added: 
    

Modified: 
    llvm/include/llvm/CodeGen/BasicTTIImpl.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CodeGen/BasicTTIImpl.h b/llvm/include/llvm/CodeGen/BasicTTIImpl.h
index 21e3d93ded22..0aca5cf3844b 100644
--- a/llvm/include/llvm/CodeGen/BasicTTIImpl.h
+++ b/llvm/include/llvm/CodeGen/BasicTTIImpl.h
@@ -702,24 +702,25 @@ class BasicTTIImplBase : public TargetTransformInfoImplCRTPBase<T> {
     case Instruction::ZExt:
       if (TLI->isZExtFree(SrcLT.second, DstLT.second))
         return 0;
-      break;
-    case Instruction::AddrSpaceCast:
-      if (TLI->isFreeAddrSpaceCast(Src->getPointerAddressSpace(),
-                                   Dst->getPointerAddressSpace()))
-        return 0;
-      break;
-    }
-
-    // If this is a zext/sext of a load, return 0 if the corresponding
-    // extending load exists on target.
-    if ((Opcode == Instruction::ZExt || Opcode == Instruction::SExt) &&
-        I && isa<LoadInst>(I->getOperand(0))) {
+      LLVM_FALLTHROUGH;
+    case Instruction::SExt: {
+      // If this is a zext/sext of a load, return 0 if the corresponding
+      // extending load exists on target.
+      if (I && isa<LoadInst>(I->getOperand(0))) {
         EVT ExtVT = EVT::getEVT(Dst);
         EVT LoadVT = EVT::getEVT(Src);
         unsigned LType =
           ((Opcode == Instruction::ZExt) ? ISD::ZEXTLOAD : ISD::SEXTLOAD);
         if (TLI->isLoadExtLegal(LType, ExtVT, LoadVT))
           return 0;
+      }
+      break;
+    }
+    case Instruction::AddrSpaceCast:
+      if (TLI->isFreeAddrSpaceCast(Src->getPointerAddressSpace(),
+                                   Dst->getPointerAddressSpace()))
+        return 0;
+      break;
     }
 
     // If the cast is marked as legal (or promote) then assume low cost.