[PATCH] D78723: [AArch64][SVE] Custom lowering of floating-point reductions

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes marked 5 inline comments as done.
c-rhodes added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:8418
+      if (VT.getSizeInBits() != AArch64::SVEBitsPerBlock)
+        return Op;
+
----------------
sdesmalen wrote:
> Should this return `SDValue()` because VT is not yet legal?
if `VT` weren't legal it should be caught by the check above and `SDValue()` returned.


================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-fp-reduce.ll:1
-; RUN: llc -mtriple=aarch64--linux-gnu -mattr=+sve < %s | FileCheck %s
+; RUN: llc -mtriple=aarch64--linux-gnu -mattr=+sve -asm-verbose=0 < %s | FileCheck %s
 
----------------
sdesmalen wrote:
> Why is this change required?
To remove `// kill: def $d0 killed $d0 killed $z0` from the output.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78723/new/

https://reviews.llvm.org/D78723