[PATCH] D78805: [llvm-readobj][test] - Stop using binaries in gnu-phdrs.test and refine it.

Mon Apr 27 04:15:23 PDT 2020

grimar marked an inline comment as done.
grimar added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-phdrs.test:325
+
+## Check the output when an object has no section headers.
+## RUN: llvm-objcopy --strip-sections %t64.elf %tno-shdrs.o
----------------
jhenderson wrote:
> grimar wrote:
> > jhenderson wrote:
> > > What's the reasoning from removing this from its separate test? I don't think that gives us anything.
> > The original test uses `phdrs-elf.exe-x86_64` which is removed with this patch. 
> > Also I probably see no reason for testing it separatelly either: it is not a large/complex feature.
> > 
> > Want me to restore `phdrs-elf.exe-x86_64` and keep `gnu-section-mapping-no-shdrs.test` unchanged?
> I guess it would be okay to fold it into a dedicated test for `--section-mapping`, but I think there should be a minimum of one test per user-visible option, unless two options are intricately connected. Whilst related, the `--section-mapping` option is not intricately tied into the `--program-header` option, so it makes sense to test them separately.
I see. Makes sense to me, will do.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78805/new/

https://reviews.llvm.org/D78805