[PATCH] D78502: [ARM][HWLoops] Create hardware loops for sibling loops

Mon Apr 27 03:43:01 PDT 2020

dmgreen marked an inline comment as done.
dmgreen added inline comments.
Herald added a project: LLVM.

================
Comment at: llvm/test/CodeGen/Thumb2/mve-float16regloops.ll:1219
+; CHECK-NEXT:    vfma.f16 q0, q1, r1
+; CHECK-NEXT:    bne .LBB16_10
+; CHECK-NEXT:    b .LBB16_11
----------------
dmgreen wrote:
> samparker wrote:
> > Looks like this loop shouls also be a hardware loop now?
> Yeah, I've noticed that we sometimes revert still. I will try and see what's going on in this case.
I took a look. We are reverting because this was being create as a WLS and the required branch is now backwards. So we revert to a subs bne pair. I've seen the same things comes up in other places,so have created a ticket for it separately. Maybe we can force this to not happen, or soften WLS back to a compare/branch/DLS.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78502/new/

https://reviews.llvm.org/D78502