[PATCH] D78132: [PowerPC] Refactor PPCInstrVSX.td

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai updated this revision to Diff 260264.
nemanjai added a comment.

- Reorder predicate blocks and describe the order at the start of the `Anonymous Patterns` section
- Merge duplicate predicate blocks
- Describe the file structure at the top of the file
- Set `hasSideEffects` flag to match current behaviour along with a `FIXME` where the flag needed to be explicitly set

With the side effects flag set to match current behaviour, `PPCGenInstrInfo.inc` compares identical to what we currently get. As far as I can tell, `PPCGenDAGISel.inc` differs only in predicates and the reordering of a few patterns due to `AddedComplexity` being set on a few patterns where it hadn't been set before. Presumably all the patterns have LIT tests so the fact that the LIT test runs is clean is an indication that instruction selection is unchanged.

In a follow-up patch, I'll clean up the unnecessary side effects flag and add the missing `mayLoad/mayStore` flags on some of the load/store pseudos.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78132/new/

https://reviews.llvm.org/D78132

Files:
  llvm/lib/Target/PowerPC/PPCInstrVSX.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78132.260264.patch
Type: text/x-patch
Size: 333925 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200427/a76d6609/attachment-0001.bin>