[PATCH] D78484: Providing buffer assignment for MLIR

[Ehsan via Phabricator via llvm-commits]

dfki-ehna marked 5 inline comments as done.
dfki-ehna added inline comments.


================
Comment at: mlir/lib/Transforms/BufferPlacement.cpp:437
+  target.addDynamicallyLegalOp<FuncOp>([&](FuncOp funcOp) {
+    if (!llvm::all_of(funcOp.getBlocks().front().getArguments(),
+                      isLegalBlockArg))
----------------
rriddle wrote:
> An easy way of doing this is just:
> 
> ```
> target.addDynamicallyLegalOp<FuncOp>([&](FuncOp funcOp) {
>   return typeConverter.isSignatureLegal(funcOp.getType());
> });
> ```
Thanks. We got rid of FunctionAndBlockSignatureConverter::addDynamicallyLegalFuncOp and added it directly to the TestBufferPlacement pass. So, the dialect experts also need to add this to their targets in their legalization passes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78484/new/

https://reviews.llvm.org/D78484