[PATCH] D78802: [MLIR] Propagate input side effect information

Theodore Popp via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 27 01:33:42 PDT 2020


tpopp added inline comments.


================
Comment at: mlir/lib/TableGen/OpClass.cpp:201
+  if (traitsSet.insert(traitStr).second)
+    traitsVec.push_back(traitStr);
+}
----------------
rriddle wrote:
> nit: Can you move the traitStr here?
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78802/new/

https://reviews.llvm.org/D78802





More information about the llvm-commits mailing list