[PATCH] D78776: [llvm-objdump] Print target address with evaluateMemoryOperandAddress()

Mon Apr 27 01:33:43 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.

Looks reasonable to me, with the tweak to the comment @skan suggested. Having the extra information would certainly be useful.

================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-symbol-references.yaml:10-11
+# EXEC-LABEL: <fourth>:
+# EXEC-NEXT:   400a: 8b 05 f0 0f 00 00             movl    4080(%rip), %eax  # 5000 <data1>
+# EXEC-NEXT:   4010: 8b 05 12 34 56 78             movl    2018915346(%rip), %eax  # 78567428 <data1+0x78562428>

----------------
Do we need both cases here? Does having both provide additional coverage above the previous two cases?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78776/new/

https://reviews.llvm.org/D78776