[PATCH] D78476: [dsymutil] Fix short options displayed in the help message.

Mon Apr 27 01:01:25 PDT 2020

Higuoxing added a comment.

In D78476#1992621 <https://reviews.llvm.org/D78476#1992621>, @aprantl wrote:

> Not sure how applicable this is here, but I wanted to point out that we do have a test specifically for the help text `llvm/test/tools/dsymutil/cmdline.test`. Perhaps this patch can be tested there.

Hi @aprantl

Sorry for the late response. I've checked `cmdline.test`, and these options are checked in this way.

  dsymutil --help | FileCheck %s --check-prefix=HELP
  HELP: -option1
  HELP: -option2

However, `-option` matches both `--option` and `-option`. I've also checked other tools' `cmdline.test/help.test`, which are similar to `dsymutil`'s. I guess we should use regex patterns to exactly match what we want? Do you have any suggestion?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78476/new/

https://reviews.llvm.org/D78476