[PATCH] D78458: [LAA] Move CheckingPtrGroup/PointerCheck outside class (NFC).

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 26 14:20:36 PDT 2020


Ayal added a comment.

Given that CheckingPtrGroup and PointerCheck are taken out of RuntimePointerChecking to become externally visible, would it make sense to rename them RuntimeCheckingPtrGroup and RuntimePointerCheck?



================
Comment at: llvm/include/llvm/Analysis/LoopAccessAnalysis.h:416
-  /// function.  FIXME: once check-generation is moved inside this class (after
-  /// the PtrPartition hack is removed), we could drop const.
-  typedef std::pair<const CheckingPtrGroup *, const CheckingPtrGroup *>
----------------
The const's are not dropped, but the comment is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78458/new/

https://reviews.llvm.org/D78458





More information about the llvm-commits mailing list