[PATCH] D66029: llvm-canon

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/IRCanonicalizer.h:1
+//===---------------- IRCanonicalizer.h - IR Canonicalizer ------*- C++ -*-===//
+//
----------------
Does this need to be a separate header? Can the class be contained in a anonymous namespace in the .cpp file (IRCanonicalizer.cpp) like some of the other passes? 


================
Comment at: llvm/include/llvm/Transforms/Utils/IRCanonicalizer.h:61
+  // Random constant for hashing, so the state isn't zero.
+  const uint64_t MagicHashConstant = 0x6acaa36bef8325c5ULL;
+
----------------
Is there any significance of this magic number? Can you either set this by a cl::opt or generated at runtime  (maybe something using srand (time(NULL))) ? 



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66029/new/

https://reviews.llvm.org/D66029