[PATCH] D78656: [MLIR] Add a tests for out of tree dialect example.

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs added inline comments.


================
Comment at: mlir/test/Examples/standalone/test.toy:1
+# RUN: echo %host_cxx; %cmake %mlir_src_root/examples/standalone -DCMAKE_CXX_COMPILER=%host_cxx -DCMAKE_C_COMPILER=%host_cc -DMLIR_DIR=%llvm_lib_dir/cmake/mlir ; %cmake --build . --target check-standalone-opt | tee output | FileCheck %s
+
----------------
Should this be `tee %t` so there's no chance of collisions with other tests writing to the same generically-named file?


================
Comment at: mlir/test/lit.site.cfg.py.in:26
 config.host_cxx = "@HOST_CXX@"
+config.host_cmake = "cmake" # How do we get the path to cmake?
 # Note: ldflags can contain double-quoted paths, so must use single quotes here.
----------------
I think you want "@CMAKE_COMMAND@"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78656/new/

https://reviews.llvm.org/D78656