[PATCH] D78769: [AArch64][GlobalISel] Select immediate forms of compares by wiggling constants

[Amara Emerson via Phabricator via llvm-commits]

aemerson added a comment.

I'm a bit uneasy about the API here, it seems very easy to forget to update the predicate in the caller.

What if we returned a pair<MachineInstr*, Predicate> from that function? That way callers will be forced to somewhat deal with the predicate returned in order to access the MI, making it less likely it'll be forgotten.

The other approach could be to have a separate emitIntegerCompareWithPredUpdate() call that does this behavior as a wrapper around emitIntegerCompare().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78769/new/

https://reviews.llvm.org/D78769