[PATCH] D77213: Handle part-word LL/SC in atomic expansion pass

Brian Cain via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 25 10:36:48 PDT 2020


bcain added a comment.

If I apply this patch I am still able to encounter this `unreachable` during a build.  I can share repro details.



================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:572
     unsigned ValueSize = getAtomicOpSize(AI);
     if (ValueSize < MinCASSize) {
       llvm_unreachable(
----------------
Is this guard related to the patch?  Seems like it should also be changed, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77213/new/

https://reviews.llvm.org/D77213





More information about the llvm-commits mailing list