[PATCH] D78856: [Support] Simplify and optimize ThreadPool

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 25 10:04:50 PDT 2020


aganea added inline comments.


================
Comment at: llvm/lib/Support/ThreadPool.cpp:57
+          std::lock_guard<std::mutex> LockGuard(QueueLock);
+          Notify = --ActiveThreads == 0 && Tasks.empty();
         }
----------------
Is it worth generalizing the notify condition between this and `ThreadPool::wait()` below, to ease future maintenance/comprehension?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78856/new/

https://reviews.llvm.org/D78856





More information about the llvm-commits mailing list