[PATCH] D77143: [llvm-dwp] Refuse DWARFv5 input DWP files.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin marked 2 inline comments as done.
ikudrin added inline comments.


================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:657
+        return make_error<DWPError>(
+            std::string("unsupported tu_index version: ") +
+            utostr(TUIndex.getVersion()) +
----------------
dblaikie wrote:
> I think if you make this first thing a StringRef or Twine, rather than a std::string, you should be able to concatenate the rest without needing to wrap the last literal in a std::string, eg:
> 
> ```
> StringRef("foo")  + utostr(x) + "bar"
> ```
Thanks! I've applied not exactly your variant, but since `utostr()` returns `std::string`, the wrappings of the first and the last string are not necessary at all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77143/new/

https://reviews.llvm.org/D77143