[PATCH] D78592: [mlir][SCCP] Add support for propagating across symbol based calls

Fri Apr 24 21:05:52 PDT 2020

bondhugula added a comment.

In D78592#1996277 <https://reviews.llvm.org/D78592#1996277>, @rriddle wrote:

> In D78592#1996224 <https://reviews.llvm.org/D78592#1996224>, @bondhugula wrote:
>
> > Looks great!
> >
> > > It assumes that the arguments of callable can be tracked so long as we know that all of the uses are calls.
> >
> > When can the arguments not be tracked? And shouldn't the CallableOpInterface guarantee that?
>
>
> I thought I had a reason originally, but after thinking about it the constraints of symbol visibility already guarantee this today.

It'd be good to incorporate this understanding somewhere as a comment.

In D78592#2002333 <https://reviews.llvm.org/D78592#2002333>, @rriddle wrote:

> Anything else here Uday?

Sorry about the delay - I should be able to get back on this by later today.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78592/new/

https://reviews.llvm.org/D78592