[PATCH] D49116: Setup clang-format as an Arcanist linter

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 24 17:53:58 PDT 2020


rnk added a comment.

This doesn't work on Windows:

  $ arc diff
  Linting...
   Exception
  Some linters failed:
      - CommandException: Command failed with error #1!
        COMMAND
        utils/arcanist/clang-format.sh "lld/COFF/Driver.cpp"
  
        STDOUT
        (empty)
  
        STDERR
        'utils' is not recognized as an internal or external command,
        operable program or batch file.
  
  (Run with `--trace` for a full exception trace.)

I would complain that one should not assume bash exists when writing portable code, but now that LLVM has git as a dependency, we can assume bash exists. I have a fix I can send along.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49116/new/

https://reviews.llvm.org/D49116





More information about the llvm-commits mailing list