[PATCH] D77231: [lld] Support --lto-emit-asm and --plugin-opt=emit-asm

Fri Apr 24 16:49:03 PDT 2020

hoyFB added a comment.

In D77231#1995662 <https://reviews.llvm.org/D77231#1995662>, @MaskRay wrote:

> @hoyFB LLVM is very loose by giving commit access to everyone, but we are expecting people to act in good faith. Your initial action (adding a colleague (with all due respect) who has no contribution to lld yet) and your word `I'm planning to land this shortly` made me very concerned that you wanted to bypass the usual review process. (I would not have overreacted if I had seen some lld contribution from you)

@MaskRay I think there is a misunderstanding going on here. I was hoping to have this change in sooner because we really need it on our side. That being said, we didn't intend to bypass any code reviewers to commit the change silently, as you can see that the change has been pending here for three weeks and all feedbacks from all reviewers have been addressed. If by an accident there are more feedbacks after this is committed, we will always address them in a new change or revert this change.

================
Comment at: lld/test/ELF/lto/emit-asm.ll:4
+; RUN: ld.lld --lto-emit-asm -shared %t.o -o - | FileCheck %s
+; RUN: ld.lld --plugin-opt=emit-asm --plugin-opt=lto-partitions=2\
+; RUN:    -shared %t.o -o %t2.s
----------------
MaskRay wrote:
> Join the two lines.
> 
> I mentioned this in a previous comment.
Line 3 and Line 4?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77231/new/

https://reviews.llvm.org/D77231