[PATCH] D78765: [TRE] Fix bug in handling of switch statements

Layton Kifer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 24 15:44:11 PDT 2020


laytonio updated this revision to Diff 260008.
laytonio added a comment.

This now fixes both repos of the crash. I removed a test that relied on the bug and actually didn't produce valid output. Added the case with a single branch as a test case. However, all this switch handling really does is propagate a constant. Maybe we should remove it entirely and expect that the constant propagation passes do this for us.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78765/new/

https://reviews.llvm.org/D78765

Files:
  llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp
  llvm/test/Transforms/TailCallElim/accum_recursion.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78765.260008.patch
Type: text/x-patch
Size: 6992 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200424/86ff3d69/attachment.bin>


More information about the llvm-commits mailing list