[PATCH] D78790: [mlir][DialectConversion] Add support for properly tracking replaceUsesOfBlockArgument

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey marked an inline comment as done.
GMNGeoffrey added inline comments.


================
Comment at: mlir/test/lib/Dialect/Test/TestPatterns.cpp:251
+    auto illegalOp =
+        rewriter.create<ILLegalOpF>(op->getLoc(), rewriter.getF32Type());
+    rewriter.replaceUsesOfBlockArgument(op->getRegion(0).front().getArgument(0),
----------------
rriddle wrote:
> GMNGeoffrey wrote:
> > Not this revision, but WTF is with the capitalization on ILLegal?
> I think I wrote this at like 3 am, i.e., when I was ILL myself.
:grin:


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78790/new/

https://reviews.llvm.org/D78790