[PATCH] D78582: [InstCombine] substitute equivalent constant to reduce logic-of-icmps

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 24 14:39:57 PDT 2020


nikic added a comment.

> I'm looking into this, and i believe those are improvements, not regressions.

Yeah, I agree that the changes look okay. Always hard to tell when some innocuous single instruction change triggers a snowball effect because it trips an inlining heuristic somewhere.

> Absolutely, more specifically libc++ (you) vs libstdc++ (me) makes difference.

Oh, good point!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78582/new/

https://reviews.llvm.org/D78582





More information about the llvm-commits mailing list