[PATCH] D78779: [lld][WebAssembly] Fix crash on function signature mismatch with --relocatable
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 24 14:39:53 PDT 2020
aheejin added inline comments.
================
Comment at: lld/wasm/SymbolTable.cpp:648
+ replaceSymbol<DefinedFunction>(sym, debugName, WASM_SYMBOL_BINDING_LOCAL,
+ nullptr, func);
return func;
----------------
I'm not very familiar with this part of code. Does making the symbols local here prevent this from being emitted in the output object file? Why not `sym->getName()` bug `debugName` now?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78779/new/
https://reviews.llvm.org/D78779
More information about the llvm-commits
mailing list