[PATCH] D78770: [X86][ArgumentPromotion] Allow Argument Promotion if caller and callee disagree on 512-bit vectors support if the arguments are scalar.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 24 14:05:53 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

Generally, I'm a little concerned about continuing to extend this approach.  In particular, the IR doesn't make it obvious which attributes are supposed to affect the ABI, and the check in X86TTIImpl::areFunctionArgsABICompatible() seems overly specific.  But I guess this particular patch doesn't really make that problem any worse.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78770/new/

https://reviews.llvm.org/D78770





More information about the llvm-commits mailing list