[PATCH] D78796: [Support] Refactor LEB128 encoding into an input iterator

Nicolas Guillemot via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 24 14:05:51 PDT 2020


nlguillemot updated this revision to Diff 259983.
nlguillemot added a comment.

Removed unnecessary `inline`

  diff
  diff --git a/llvm/include/llvm/Support/LEB128.h b/llvm/include/llvm/Support/LEB128.h
  index 2549ff86ccd..8c70b41d27c 100644
  --- a/llvm/include/llvm/Support/LEB128.h
  +++ b/llvm/include/llvm/Support/LEB128.h
  @@ -182,8 +182,8 @@ unsigned encodeLEB128(const ValueT &Value, bool IsSigned, uint8_t *p,
   /// Utility function to encode a SLEB128 or ULEB128 value to an output stream.
   /// Returns the length in bytes of the encoded value.
   template <class ValueT>
  -inline unsigned encodeLEB128(const ValueT &Value, bool IsSigned,
  -                             raw_ostream &OS, unsigned PadTo = 0) {
  +unsigned encodeLEB128(const ValueT &Value, bool IsSigned, raw_ostream &OS,
  +                      unsigned PadTo = 0) {
     uint64_t TellBefore = OS.tell();
     std::copy(LEB128InputIterator<ValueT>(Value, IsSigned, PadTo),
               LEB128InputIterator<ValueT>(), raw_ostream_iterator<uint8_t>(OS));


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78796/new/

https://reviews.llvm.org/D78796

Files:
  llvm/include/llvm/Support/LEB128.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78796.259983.patch
Type: text/x-patch
Size: 10166 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200424/7bf306b4/attachment.bin>


More information about the llvm-commits mailing list