[PATCH] D78819: [gold] Simplify with StringRef::consume_front. NFC

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Thanks for the nice cleanup. I spotted an issue though, see below.



================
Comment at: llvm/tools/gold/gold-plugin.cpp:270
+    } else if (opt.consume_front("jobs=")) {
       StringRef Num(opt_ + 5);
       if (!get_threadpool_strategy(Num))
----------------
I think this one needs a fix, presumably just Num(opt_) now?

Looks like there isn't a good way to test this unfortunately, unless the garbage read causes the get_threadpool_strategy call below to fail. Can you find or add a way to test this parameter?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78819/new/

https://reviews.llvm.org/D78819