[PATCH] D76085: [DWARFLinker][dsymutil][NFC] add section index into address range.

[Alexey Lapshin via Phabricator via llvm-commits]

avl marked 14 inline comments as done.
avl added inline comments.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:1477
   uint64_t OrigLowPc =
       dwarf::toAddress(OrigUnitDie.find(dwarf::DW_AT_low_pc), -1ULL);
   // Ranges addresses are based on the unit's low_pc. Compute the
----------------
clayborg wrote:
> constexpr MAX_ADDR or INVALID_ADDR and do we need to use dwarf::toSectionedAddress() now?
We do not need to have SectionedAddress here. LowPc/Unit.getLowPc() is a property of Compile unit. We could not have values pointing to different sections here. And Unit.getLowPc() is recalculated in terms of resulting binary address : 

LowPc = std::min(*LowPc, FuncLowPc.Address + PcOffset);


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76085/new/

https://reviews.llvm.org/D76085