[PATCH] D78802: [MLIR] Propagate input side effect information

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added a comment.
This revision is now accepted and ready to land.

Thanks! It looks like the failures are real, can you look into those?



================
Comment at: mlir/include/mlir/Support/LLVM.h:60
 class APFloat;
+
 } // end namespace llvm
----------------
This looks unrelated.


================
Comment at: mlir/lib/TableGen/OpClass.cpp:201
+  if (traitsSet.insert(traitStr).second)
+    traitsVec.push_back(traitStr);
+}
----------------
nit: Can you move the traitStr here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78802/new/

https://reviews.llvm.org/D78802