[PATCH] D78790: [mlir][DialectConversion] Add support for properly tracking replaceUsesOfBlockArgument

[River Riddle via Phabricator via llvm-commits]

rriddle marked 4 inline comments as done.
rriddle added inline comments.


================
Comment at: mlir/lib/Transforms/DialectConversion.cpp:200
   /// operations as necessary.
-  // FIXME(riverriddle) The 'mapping' parameter is only necessary because the
-  // implementation of replaceUsesOfBlockArgument is buggy.
----------------
GMNGeoffrey wrote:
> Does this mean the mapping parameter is no longer necessary? Seems like there's still something to fix if it shouldn't be necessary
It was only necessary because of the replaceUsesOfBlockArgument bug when I originally wrote this, but now it is necessary for other reasons.


================
Comment at: mlir/test/lib/Dialect/Test/TestPatterns.cpp:251
+    auto illegalOp =
+        rewriter.create<ILLegalOpF>(op->getLoc(), rewriter.getF32Type());
+    rewriter.replaceUsesOfBlockArgument(op->getRegion(0).front().getArgument(0),
----------------
GMNGeoffrey wrote:
> Not this revision, but WTF is with the capitalization on ILLegal?
I think I wrote this at like 3 am, i.e., when I was ILL myself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78790/new/

https://reviews.llvm.org/D78790