[PATCH] D78555: [DebugInfo][DWARF64] Fix dumping pre-standard .debug_str_offsets.dwo sections.

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-str-offsets-invalid-5.s:13
+# INVALIDSECTIONLENGTH: .debug_str_offsets contents:
+# INVALIDSECTIONLENGTH: 0x00000000: Gap, length = 1
----------------
ikudrin wrote:
> wolfgangp wrote:
> > This isn't particularly important but it would be nice to emit a more precise error message on a degenerate .debug_str_offsets section like this.
> Currently, we report the irregularities found in the section, in some other way, but still. Did you mean some specific case which should be reported better/differently?
Just this particular case, where the section isn't big enough to accommodate even one single entry, let alone a contribution header. I thought it might be a bit more user-friendly to say something like "the section is too small to contain any meaningful information" instead of reporting a gap, which might be confusing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78555/new/

https://reviews.llvm.org/D78555